NO-ISSUE: Lower IRI deletion log verbosity by djoshy · Pull Request #6119 · openshift/machine-config-operator

djoshy · 2026-06-02T17:07:54Z

This is spamming controller logs on every sync and makes things harder to debug.

Summary by CodeRabbit

Chores
- Adjusted internal logging verbosity for better debugging efficiency.

openshift-merge-bot · 2026-06-02T17:07:57Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-06-02T17:07:58Z

@djoshy: This pull request explicitly references no jira issue.

Details

In response to this:

This is spamming controller logs on every sync and makes things harder to debug.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-02T17:08:08Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a50c3d44-cc48-474d-ae4d-411817e13c4d

📥 Commits

Reviewing files that changed from the base of the PR and between 26d41f7 and 8e518a1.

📒 Files selected for processing (1)

pkg/controller/internalreleaseimage/internalreleaseimage_controller.go

Walkthrough

The pull request adjusts the verbosity level of a single log message in the InternalReleaseImage controller's deletion path. When an InternalReleaseImage resource is already deleted, the log message now uses verbosity level V(4) instead of V(2), making it less prominent in controller logs.

Changes

Log Verbosity Adjustment

Layer / File(s)	Summary
Log level adjustment for deleted InternalReleaseImage `pkg/controller/internalreleaseimage/internalreleaseimage_controller.go`	The verbosity level for logging when an InternalReleaseImage is already deleted is increased from V(2) to V(4) in the syncInternalReleaseImage function.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Ipv6 And Disconnected Network Test Compatibility	⚠️ Warning	PR adds Ginkgo e2e tests with IPv4 hardcoded localhost (127.0.0.1) and external quay.io image references incompatible with IPv6 disconnected environments.	Replace 127.0.0.1 with IPv6 support (::1), handle external images via cluster internal registry, and use GetIPAddressFamily() helper for IP family detection.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely summarizes the main change: lowering log verbosity for InternalReleaseImage (IRI) deletion by changing from V(2) to V(4).
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The repository uses standard Go testing, not Ginkgo. No Ginkgo test framework found in codebase (0 imports). PR modifies log verbosity only; no test files added or modified.
Test Structure And Quality	✅ Passed	PR only modifies controller log message verbosity (controller.go +1/-1), not Ginkgo test code. Repository uses standard Go testing, not Ginkgo. Check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests are added in this PR. The change only modifies log verbosity in a controller file, making the MicroShift compatibility check not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR contains only a log verbosity change (V(2) to V(4)) in controller code, not new e2e tests. The SNO Test Compatibility check applies only to new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility	✅ Passed	PR changes only log verbosity level (V(2)→V(4)) in controller code; no scheduling constraints, pod specs, deployments, node selectors, affinity rules, or topology assumptions introduced.
Ote Binary Stdout Contract	✅ Passed	The PR changes klog verbosity from V(2) to V(4) in a controller method, not process-level code. klog outputs to stderr via flag.Set("logtostderr", "true"), so no stdout contract violation.
No-Weak-Crypto	✅ Passed	PR contains only a logging verbosity change (V(2)→V(4)) in internalreleaseimage_controller.go with no weak crypto algorithms, custom crypto implementations, or insecure secret comparisons.
Container-Privileges	✅ Passed	PR modifies only Go source file, not K8s manifests. Changes log verbosity (V(2) to V(4)). Container-privileges check for manifests is not applicable.
No-Sensitive-Data-In-Logs	✅ Passed	The log statement logs only a resource key (namespace/name format), which is non-sensitive. The change reduces verbosity from V(2) to V(4), which is appropriate for operational noise reduction.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

isabella-janssen

/lgtm

isabella-janssen · 2026-06-02T17:09:45Z

/verified bypass

Just a log change, doesn't need verification

openshift-ci · 2026-06-02T17:09:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/controller/internalreleaseimage/OWNERS~~ [djoshy,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2026-06-02T17:09:58Z

@isabella-janssen: The verified label has been added.

Details

In response to this:

/verified bypass

Just a log change, doesn't need verification

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-bot · 2026-06-02T17:10:15Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-upgrade
/test e2e-gcp-op-ocl-part1
/test e2e-gcp-op-ocl-part2
/test e2e-gcp-op-part1
/test e2e-gcp-op-part2
/test e2e-gcp-op-single-node
/test e2e-hypershift

djoshy · 2026-06-02T17:13:22Z

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-op-ocl-part1
/override ci/prow/e2e-gcp-op-ocl-part2
/override ci/prow/e2e-gcp-op-part1
/override ci/prow/e2e-gcp-op-part2
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-hypershift

openshift-ci · 2026-06-02T17:13:47Z

@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-upgrade, ci/prow/e2e-gcp-op-ocl-part1, ci/prow/e2e-gcp-op-ocl-part2, ci/prow/e2e-gcp-op-part1, ci/prow/e2e-gcp-op-part2, ci/prow/e2e-gcp-op-single-node, ci/prow/e2e-hypershift

Details

In response to this:

/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-aws-ovn-upgrade
/override ci/prow/e2e-gcp-op-ocl-part1
/override ci/prow/e2e-gcp-op-ocl-part2
/override ci/prow/e2e-gcp-op-part1
/override ci/prow/e2e-gcp-op-part2
/override ci/prow/e2e-gcp-op-single-node
/override ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-06-02T17:45:20Z

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

NO-ISSUE: Lower IRI deletion log verbosity

internalreleaseimage: lower deletion log verbosity

8e518a1

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 2, 2026

isabella-janssen reviewed Jun 2, 2026

View reviewed changes

openshift-ci Bot requested review from andfasano and pawanpinjarkar June 2, 2026 17:09

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jun 2, 2026

openshift-ci Bot assigned isabella-janssen Jun 2, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2026

openshift-merge-bot Bot merged commit bf66c0b into openshift:main Jun 2, 2026
17 checks passed

djoshy deleted the hot-fix-iri-log branch June 2, 2026 18:47

yuqi-zhang mentioned this pull request Jul 27, 2026

[release-4.22]AGENT-1548: Backport NoRegistryClusterInstall feature to release-4.22 #6323

Merged

bfournie pushed a commit to bfournie/machine-config-operator that referenced this pull request Jul 27, 2026

Merge pull request openshift#6119 from djoshy/hot-fix-iri-log

eb98061

NO-ISSUE: Lower IRI deletion log verbosity

Navigation Menu

Uh oh!

NO-ISSUE: Lower IRI deletion log verbosity - #6119

NO-ISSUE: Lower IRI deletion log verbosity#6119
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
djoshy:hot-fix-iri-log

djoshy commented Jun 2, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-merge-bot Bot commented Jun 2, 2026

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Uh oh!

coderabbitai Bot commented Jun 2, 2026 •

edited

Loading

❌ Failed checks (1 warning)

Uh oh!

isabella-janssen left a comment

Uh oh!

isabella-janssen commented Jun 2, 2026

Uh oh!

openshift-ci Bot commented Jun 2, 2026

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 2, 2026

Uh oh!

djoshy commented Jun 2, 2026

Uh oh!

openshift-ci Bot commented Jun 2, 2026

Uh oh!

Uh oh!

openshift-ci Bot commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

djoshy commented Jun 2, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jun 2, 2026

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Uh oh!

coderabbitai Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

isabella-janssen left a comment

Choose a reason for hiding this comment

Uh oh!

isabella-janssen commented Jun 2, 2026

Uh oh!

openshift-ci Bot commented Jun 2, 2026

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 2, 2026

Uh oh!

djoshy commented Jun 2, 2026

Uh oh!

openshift-ci Bot commented Jun 2, 2026

Uh oh!

Uh oh!

openshift-ci Bot commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

djoshy commented Jun 2, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 2, 2026 •

edited

Loading